Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ORC related failed UT #417

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix ORC related failed UT #417

merged 1 commit into from
Nov 23, 2023

Conversation

chenxu14
Copy link

No description provided.

@zuochunwei
Copy link
Collaborator

@rui-mo could you have a look for this PR

@rui-mo
Copy link
Collaborator

rui-mo commented Oct 19, 2023

Thanks. Can we open this change to Velox upstream? We can pick them back to this branch.

@chenxu14
Copy link
Author

Thanks. Can we open this change to Velox upstream? We can pick them back to this branch.

There are already some PR's Including this part of logic, such as 6156 and 6240, Do you think there is a need to submit a new PR？cc @Yuhta

@rui-mo
Copy link
Collaborator

rui-mo commented Oct 20, 2023

@chenxu14 Thanks, I see. Maybe we can keep this PR in our local repo to get ORC work with minimal change.

@chenxu14 chenxu14 mentioned this pull request Oct 20, 2023
Closed
@PHILO-HE PHILO-HE force-pushed the update branch 3 times, most recently from 34187ee to 4032e68 Compare October 30, 2023 01:28
@PengleiShi
Copy link

@chenxu14 Thanks, I see. Maybe we can keep this PR in our local repo to get ORC work with minimal change.

@rui-mo any update here?

@JkSelf JkSelf force-pushed the update branch 2 times, most recently from c7837d9 to dfd7071 Compare November 8, 2023 11:54
@rui-mo
Copy link
Collaborator

rui-mo commented Nov 9, 2023

@chenxu14 We are frequently rebasing the base branch. Could you rebase this PR?

@zhouyuan
Copy link
Collaborator

It looks like the diff is wrong as we force-push to update branch, the workable commit is this one:

47ed824

@FelixYBW FelixYBW force-pushed the update branch 4 times, most recently from 4d877e0 to f68b4c0 Compare November 14, 2023 07:09
@PengleiShi PengleiShi mentioned this pull request Nov 15, 2023
Open
@FelixYBW FelixYBW force-pushed the update branch 3 times, most recently from e3d9542 to 17644f8 Compare November 17, 2023 17:30
@JkSelf JkSelf force-pushed the update branch 2 times, most recently from f8e0c6d to 8d8b7d5 Compare November 21, 2023 05:11
zhouyuan pushed a commit to GlutenPerfBot/velox that referenced this pull request Dec 19, 2023
@chenxu14 @zhouyuan
Fix ORC related failed UT (oap-project#417)
cb913a6
zhouyuan pushed a commit to GlutenPerfBot/velox that referenced this pull request Dec 19, 2023
@chenxu14 @zhouyuan
Fix ORC related failed UT (oap-project#417)
d60bd25
zhouyuan pushed a commit to GlutenPerfBot/velox that referenced this pull request Dec 20, 2023
@chenxu14 @zhouyuan
Fix ORC related failed UT (oap-project#417)
092d16b
zhouyuan pushed a commit to GlutenPerfBot/velox that referenced this pull request Dec 20, 2023
@chenxu14 @zhouyuan
Fix ORC related failed UT (oap-project#417)
58f038c
zhouyuan pushed a commit to GlutenPerfBot/velox that referenced this pull request Dec 21, 2023
@chenxu14 @zhouyuan
Fix ORC related failed UT (oap-project#417)
a5cede4
zhouyuan pushed a commit to GlutenPerfBot/velox that referenced this pull request Dec 22, 2023
@chenxu14 @zhouyuan
Fix ORC related failed UT (oap-project#417)
53ad3b8
zhouyuan pushed a commit to GlutenPerfBot/velox that referenced this pull request Dec 22, 2023
@chenxu14 @zhouyuan
Fix ORC related failed UT (oap-project#417)
4d5c069
zhztheplayer pushed a commit that referenced this pull request Dec 25, 2023
@chenxu14 @zhztheplayer
Fix ORC related failed UT (#417)
7297d5d
zhztheplayer pushed a commit that referenced this pull request Dec 27, 2023
@chenxu14 @zhztheplayer
Fix ORC related failed UT (#417)
b6c4cff
zhztheplayer pushed a commit that referenced this pull request Dec 27, 2023
@chenxu14 @zhztheplayer
Fix ORC related failed UT (#417)
3fe9c52
zhztheplayer pushed a commit that referenced this pull request Dec 28, 2023
@chenxu14 @zhztheplayer
Fix ORC related failed UT (#417)
39f6b03
zhztheplayer pushed a commit that referenced this pull request Dec 29, 2023
@chenxu14 @zhztheplayer
Fix ORC related failed UT (#417)
14c0a3f
marin-ma pushed a commit that referenced this pull request Jan 2, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
2814e56
marin-ma pushed a commit that referenced this pull request Jan 2, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
248842c
marin-ma pushed a commit that referenced this pull request Jan 3, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
9688ff2
marin-ma pushed a commit that referenced this pull request Jan 3, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
971b4a2
marin-ma pushed a commit that referenced this pull request Jan 4, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
4919cbe
marin-ma pushed a commit that referenced this pull request Jan 5, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
2f0c55b
marin-ma pushed a commit that referenced this pull request Jan 5, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
e41474f
marin-ma pushed a commit that referenced this pull request Jan 8, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
8138642
GlutenPerfBot pushed a commit to GlutenPerfBot/velox that referenced this pull request Jan 8, 2024
@chenxu14
Fix ORC related failed UT (oap-project#417)
7e835f1
GlutenPerfBot pushed a commit to GlutenPerfBot/velox that referenced this pull request Jan 9, 2024
@chenxu14
Fix ORC related failed UT (oap-project#417)
e7110e1
marin-ma pushed a commit that referenced this pull request Jan 10, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
d806bab
marin-ma pushed a commit that referenced this pull request Jan 11, 2024
@chenxu14 @marin-ma
Fix ORC related failed UT (#417)
5674e39
GlutenPerfBot pushed a commit to GlutenPerfBot/velox that referenced this pull request Jan 11, 2024
@chenxu14
Fix ORC related failed UT (oap-project#417)
72735af
GlutenPerfBot pushed a commit to GlutenPerfBot/velox that referenced this pull request Jan 12, 2024
@chenxu14
Fix ORC related failed UT (oap-project#417)
a6512a2
GlutenPerfBot pushed a commit to GlutenPerfBot/velox that referenced this pull request Jan 13, 2024
@chenxu14
Fix ORC related failed UT (oap-project#417)
a7284b3
GlutenPerfBot pushed a commit to GlutenPerfBot/velox that referenced this pull request Jan 14, 2024
@chenxu14
Fix ORC related failed UT (oap-project#417)
af01880
GlutenPerfBot pushed a commit to GlutenPerfBot/velox that referenced this pull request Jan 15, 2024
@chenxu14
Fix ORC related failed UT (oap-project#417)
b5b0e33
rui-mo pushed a commit that referenced this pull request Jan 15, 2024
@chenxu14 @rui-mo
Fix ORC related failed UT (#417)
0f1ebb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chenxu14 @zuochunwei @rui-mo @PengleiShi @zhouyuan @kecookier @JkSelf